Enable multi-process DataLoader for dreambooth - #950
Merged
patil-suraj merged 1 commit intoOct 26, 2022
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
This makes sense to me! @patil-suraj mind taking a look here? |
patil-suraj
approved these changes
Oct 26, 2022
patil-suraj
left a comment
patil-suraj
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot @skirsten , lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple change enables the DataLoader to prefetch the next data async. More info in the docs.
This resulted in a 35% speedup for me and utilizes the GPU power better (as the data loading is not blocking the GPU):
(green = new, blue = old)
The same can probably also be applied to all the other DataLoaders but I do not have the time to test them.